support read rustup toolchain from env#88
Open
Bandeapart1964 wants to merge 1 commit into
Open
Conversation
Owner
|
Okay, but what's the point of using another version rather than the stable? |
Author
|
stable is not a fixed version number, if it build fails for some reasons, then I can specified to last available version. another reason is when i already installed a toolchain and use it in my project, I don't expect download another one when building code forge. |
Author
|
since the cargokit use rustup specified toolchain before run cargo, so it will ignore default toolchain in system, that means code forege always use stable rust toolchain, even I set another one as default in my system |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I added a line to read rustup toolchain version from shell environment “RUSTUP_TOOLCHAIN”, it allows user to use an installed or speficied toolchain, rather than force use 'stable'.
ps. The environment name from the rustup book
thx your work!